Skip to content

Commit

Permalink
Bump Maven JavaDoc plugin from 3.4.0 to 3.6.3 to fix build failure
Browse files Browse the repository at this point in the history
[This build](https://github.com/google/google-java-format/actions/runs/7891365432/job/21535541300?pr=1060) for #1060 failed on (only) Windows under GraalVM for Native and I suspect that this change may fix this problem:

```
Error:  Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.4.0:jar (attach-javadocs) on project google-java-format: MavenReportException: Error while generating Javadoc:
Error:  Exit code: 1 - Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\CloseOp.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\CommentsHelper.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\Doc.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\DocBuilder.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\FormatterDiagnostic.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\FormattingError.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\Indent.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\Input.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\InputOutput.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\CommandLineOptions.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\CommandLineOptionsParser.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\DimensionHelpers.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\filer\FormattingFiler.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\filer\FormattingJavaFileObject.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\FormatFileCallable.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\Formatter.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\FormatterException.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\GoogleJavaFormatTool.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\GoogleJavaFormatToolProvider.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\ImportOrderer.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\java17\Java17InputAstVisitor.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\java21\Java21InputAstVisitor.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\JavaCommentsHelper.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\JavacTokens.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\javadoc\CharStream.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\javadoc\JavadocFormatter.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\javadoc\JavadocLexer.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\javadoc\JavadocWriter.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\javadoc\NestingCounter.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\javadoc\Token.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\JavaFormatterOptions.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\JavaInput.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\JavaInputAstVisitor.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\JavaOutput.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\Main.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\ModifierOrderer.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\RemoveUnusedImports.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\Replacement.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\SnippetFormatter.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\StringWrapper.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\Trees.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\TypeNameClassifier.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\UsageException.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\Newlines.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\Op.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\OpenOp.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\OpsBuilder.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\Output.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\target\generated-sources\java\com\google\googlejavaformat\java\GoogleJavaFormatVersion.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\target\generated-sources\annotations\com\google\googlejavaformat\java\AutoOneOf_JavaInputAstVisitor_AnnotationOrModifier.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\target\generated-sources\annotations\com\google\googlejavaformat\java\AutoValue_FormatFileCallable_Result.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\target\generated-sources\annotations\com\google\googlejavaformat\java\AutoValue_JavaFormatterOptions.java...
Error:  Loading source file D:\a\google-java-format\google-java-format\core\target\generated-sources\annotations\com\google\googlejavaformat\java\AutoValue_JavaInputAstVisitor_DeclarationModifiersAndTypeAnnotations.java...
Error:  Loading source files for package com.google.googlejavaformat...
Error:  Loading source files for package com.google.googlejavaformat.java...
Error:  Loading source files for package com.google.googlejavaformat.java.filer...
Error:  Loading source files for package com.google.googlejavaformat.java.java17...
Error:  Loading source files for package com.google.googlejavaformat.java.java21...
Error:  Loading source files for package com.google.googlejavaformat.java.javadoc...
Error:  Constructing Javadoc information...
Error:  D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\DimensionHelpers.java:18: error: package com.sun.source.tree is not visible
Error:  import com.sun.source.tree.AnnotatedTypeTree;
Error:                       ^
Error:    (package com.sun.source.tree is declared in module jdk.compiler, but module com.google.googlejavaformat does not read it)
Error:  D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\DimensionHelpers.java:19: error: package com.sun.source.tree is not visible
Error:  import com.sun.source.tree.AnnotationTree;

(...)
```

@cushon @cpovirk merge?

Fixes #1061

COPYBARA_INTEGRATE_REVIEW=#1061 from vorburger:maven-javadoc-plugin c3c4b6f
PiperOrigin-RevId: 606705880
  • Loading branch information
vorburger authored and google-java-format Team committed Feb 13, 2024
1 parent 6b4828a commit 59b09fa
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
<errorprone.version>2.16</errorprone.version>
<auto-value.version>1.9</auto-value.version>
<auto-service.version>1.0.1</auto-service.version>
<maven-javadoc-plugin.version>3.4.0</maven-javadoc-plugin.version>
<maven-javadoc-plugin.version>3.6.3</maven-javadoc-plugin.version>
<maven-source-plugin.version>3.2.1</maven-source-plugin.version>
</properties>

Expand Down Expand Up @@ -172,7 +172,7 @@
</plugin>
<plugin>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.4.0</version>
<version>${maven-javadoc-plugin.version}</version>
</plugin>
<plugin>
<artifactId>maven-gpg-plugin</artifactId>
Expand Down Expand Up @@ -260,7 +260,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.4.0</version>
<version>${maven-javadoc-plugin.version}</version>
<configuration>
<doclint>none</doclint>
</configuration>
Expand Down

0 comments on commit 59b09fa

Please sign in to comment.