Skip to content

Commit

Permalink
Build native binary in CI (fixes #894)
Browse files Browse the repository at this point in the history
  • Loading branch information
vorburger committed Feb 10, 2024
1 parent 297dda4 commit de50736
Show file tree
Hide file tree
Showing 4 changed files with 86 additions and 30 deletions.
57 changes: 36 additions & 21 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2020 The Error Prone Authors.
# Copyright 2020-2024 The Google Java Format Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -17,22 +17,22 @@ name: CI
on:
push:
branches:
- master
- master
pull_request:
branches:
- master
- master

jobs:
test:
name: "JDK ${{ matrix.java }} on ${{ matrix.os }}"
strategy:
fail-fast: false
matrix:
os: [ ubuntu-latest ]
java: [ 21, 17, 11 ]
experimental: [ false ]
os: [ubuntu-latest]
java: [GraalVM, 21, 17, 11]
experimental: [false]
include:
# Only test on macos and windows with a single recent JDK to avoid a
# Only test on MacOS and Windows with a single recent JDK to avoid a
# combinatorial explosion of test configurations.
- os: macos-latest
java: 21
Expand All @@ -43,53 +43,68 @@ jobs:
- os: ubuntu-latest
java: EA
experimental: true
- os: ubuntu-latest
java: GraalVM
experimental: false
runs-on: ${{ matrix.os }}
continue-on-error: ${{ matrix.experimental }}
steps:
- name: Cancel previous
uses: styfle/[email protected]
with:
access_token: ${{ github.token }}
- name: 'Check out repository'
- name: "Check out repository"
uses: actions/checkout@v4
- name: 'Set up JDK ${{ matrix.java }} from jdk.java.net'
- name: "Set up JDK ${{ matrix.java }} from jdk.java.net"
if: ${{ matrix.java == 'EA' }}
uses: oracle-actions/setup-java@v1
with:
website: jdk.java.net
release: ${{ matrix.java }}
- name: 'Set up JDK ${{ matrix.java }}'
if: ${{ matrix.java != 'EA' }}
- name: "Set up JDK ${{ matrix.java }} from Zulu"
if: ${{ matrix.java != 'EA' && matrix.java != 'GraalVM' }}
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java }}
distribution: 'zulu'
cache: 'maven'
- name: 'Install'
distribution: "zulu"
cache: "maven"
- name: "Set up JDK ${{ matrix.java }}"
if: ${{ matrix.java == 'GraalVM' }}
uses: graalvm/setup-graalvm@v1
with:
java-version: "21"
distribution: "graalvm-community"
github-token: ${{ secrets.GITHUB_TOKEN }}
native-image-job-reports: "true"
cache: "maven"
- name: "Install"
shell: bash
run: mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V
- name: 'Test'
- name: "Test"
shell: bash
run: mvn test -B
- name: "Native"
if: ${{ matrix.java == 'GraalVM' }}
run: mvn -Pnative -DskipTests package -pl core -am && util/test-native.sh

publish_snapshot:
name: 'Publish snapshot'
name: "Publish snapshot"
needs: test
if: github.event_name == 'push' && github.repository == 'google/google-java-format' && github.ref == 'refs/heads/master'
runs-on: ubuntu-latest
steps:
- name: 'Check out repository'
- name: "Check out repository"
uses: actions/checkout@v4
- name: 'Set up JDK 17'
- name: "Set up JDK 17"
uses: actions/setup-java@v4
with:
java-version: 17
distribution: 'zulu'
cache: 'maven'
distribution: "zulu"
cache: "maven"
server-id: sonatype-nexus-snapshots
server-username: CI_DEPLOY_USERNAME
server-password: CI_DEPLOY_PASSWORD
- name: 'Publish'
- name: "Publish"
env:
CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }}
CI_DEPLOY_PASSWORD: ${{ secrets.CI_DEPLOY_PASSWORD }}
Expand Down
28 changes: 20 additions & 8 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
# Copyright 2020-2024 The Google Java Format Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

name: Release google-java-format

on:
Expand All @@ -20,8 +34,8 @@ jobs:
uses: actions/setup-java@v4
with:
java-version: 21
distribution: 'zulu'
cache: 'maven'
distribution: "zulu"
cache: "maven"
server-id: sonatype-nexus-staging
server-username: CI_DEPLOY_USERNAME
server-password: CI_DEPLOY_PASSWORD
Expand All @@ -46,24 +60,22 @@ jobs:
CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }}
CI_DEPLOY_PASSWORD: ${{ secrets.CI_DEPLOY_PASSWORD }}
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
run:
mvn --no-transfer-progress -pl '!eclipse_plugin' -P sonatype-oss-release clean deploy -Dgpg.passphrase="${{ secrets.GPG_PASSPHRASE }}"
run: mvn --no-transfer-progress -pl '!eclipse_plugin' -P sonatype-oss-release clean deploy -Dgpg.passphrase="${{ secrets.GPG_PASSPHRASE }}"

- name: Build Eclipse plugin
run:
mvn --no-transfer-progress -pl 'eclipse_plugin' verify gpg:sign -DskipTests=true -Dgpg.passphrase="${{ secrets.GPG_PASSPHRASE }}"
run: mvn --no-transfer-progress -pl 'eclipse_plugin' verify gpg:sign -DskipTests=true -Dgpg.passphrase="${{ secrets.GPG_PASSPHRASE }}"

- name: Push tag
run: |
git push origin "v${{ github.event.inputs.version }}"
- name: Add Jars to Release Entry
- name: Add Artifacts to Release Entry
uses: softprops/[email protected]
with:
draft: true
name: ${{ github.event.input.version }}
tag_name: "v${{ github.event.inputs.version }}"
target_commitish: ${{ env.TARGET_COMMITISH }}
files: |
core/target/google-java-format-*.jar
core/target/google-java-format*
eclipse_plugin/target/google-java-format-eclipse-plugin-*.jar
2 changes: 1 addition & 1 deletion core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@
<plugin>
<groupId>org.graalvm.buildtools</groupId>
<artifactId>native-maven-plugin</artifactId>
<version>0.9.13</version>
<version>0.10.0</version>
<extensions>true</extensions>
<executions>
<execution>
Expand Down
29 changes: 29 additions & 0 deletions util/test-native.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Copyright 2024 The Google Java Format Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -euox pipefail

time java -jar core/target/google-java-format-*-all-deps.jar || true

status=-1
chmod +x core/target/google-java-format
if time core/target/google-java-format; then
status=0
else
status=$?
fi
if [[ $status -ne 2 ]]; then
echo "google-java-format_linux (native) without arguments should have printed usage help and exited with 2, but did not :("
exit 1
fi

0 comments on commit de50736

Please sign in to comment.