Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chmod +x util/test-native.sh which Copybara broke #1062

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

Fix chmod +x util/test-native.sh which Copybara broke

@cushon

Fixes #1059

FUTURE_COPYBARA_INTEGRATE_REVIEW=#1059 from vorburger:chmod-test-native 2796659

@copybara-service copybara-service bot closed this Feb 13, 2024
@copybara-service copybara-service bot deleted the test_606702689 branch February 13, 2024 20:13
@vorburger
Copy link
Member

@cushon Looks like this is indeed a Copybara bug, as this is empty, and clearing ignoring the chmod from #1059.

I'll follow-up internally (tomorrow).

@cushon
Copy link
Collaborator

cushon commented Feb 13, 2024

I think this did actually get fixed by the commit copybara pushed in 6b4828a

I think this PR is showing up as empty because the commit has been merged, and the diff for the internal review doesn't make it super clear that it's a permissions-only change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants