Make BloomFilter.bitSize() public #6923
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitPatil05
added a commit
to AmitPatil05/guava
that referenced
this pull request
Feb 3, 2024
chaoren
added
type=addition
rohit-satya
reviewed
May 13, 2024
| @@ -214,7 +214,7 @@ public long approximateElementCount() { | |||
|
|
|||
| /** Returns the number of bits in the underlying bit array. */ | |||
| @VisibleForTesting | |||
There was a problem hiding this comment.
now that we've made it public should we remove the annotation?
The documentation states the following
Do not use this interface for public or protected declarations: it is a fig leaf for bad design, and it does not prevent anyone from using the declaration---and experience has shown that they will. If the method breaks the encapsulation of its class, then its internal representation will be hard to change. Instead, use RestrictedApiChecker , which enforces fine-grained visibility policies.
| @@ -215,7 +215,7 @@ public long approximateElementCount() { | |||
|
|
|||
| /** Returns the number of bits in the underlying bit array. */ | |||
| @VisibleForTesting | |||
|
hey, anyone working on #6923? , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix issue - #6866