Skip to content

Commit

Permalink
Make buildkite push images with gcr.io at release pipeline.
Browse files Browse the repository at this point in the history
GCR will be deprecated, while the prefix `gcr.io` will be
be hosted via Artifact Registry. By adding this one extra step,
all test images will be accessible via both `gcr.io` and
`pkg.dev`.

PiperOrigin-RevId: 694278137
  • Loading branch information
milantracy authored and gvisor-bot committed Nov 8, 2024
1 parent c80684f commit 155cdcb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .buildkite/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,15 @@ steps:
if: build.branch == "master" && build.tag == null
commands:
- make ARCH=x86_64 DOCKER_PUSH_AS_LATEST=true push-all-images
- make ARCH=x86_64 REMOTE_IMAGE_PREFIX=gcr.io/gvisor-presubmit DOCKER_PUSH_AS_LATEST=true push-all-images
agents:
arch: "amd64"
- <<: *common
label: ":ship: Push all images (aarch64)"
if: build.branch == "master" && build.tag == null
commands:
- make ARCH=aarch64 DOCKER_PUSH_AS_LATEST=true push-all-images
- make ARCH=aarch64 REMOTE_IMAGE_PREFIX=gcr.io/gvisor-presubmit DOCKER_PUSH_AS_LATEST=true push-all-images
agents:
arch: "arm64"
- <<: *common
Expand Down
5 changes: 2 additions & 3 deletions images/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,8 @@ if available.
## Building and pushing images

All images can be built manually by running `build-<image>` and pushed using
`push-<image>`. Note that you can also use `build-all-images` and
`push-all-images`. Note that pushing will require appropriate permissions in the
project.
`push-<image>`. Note that you can also use `push-all-images`. Note that pushing
will require appropriate permissions in the project.

The continuous integration system can either take fine-grained dependencies on
individual `push` targets, or ensure all images are up-to-date with a single
Expand Down

0 comments on commit 155cdcb

Please sign in to comment.