netstack: move TCP state to tcp package and cleanup probe #11171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl695793246
branch
10 times, most recently
from
e060dc1
to
9844f34
Compare
copybara-service
bot
force-pushed
the
test/cl695793246
branch
4 times, most recently
from
764b316
to
3206e13
Compare
TCP probe support is implemented, unnecessarily, across the stack and and tcp packages. It can live entirely in tcp. Additionally, it is only ever set at initialization time, so support for dynamically adding/removing the probe isn't necesary. The probe is getting in the way of adding debugging for b/339664055. PiperOrigin-RevId: 695793246
copybara-service
bot
force-pushed
the
test/cl695793246
branch
from
3206e13
to
12bb996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netstack: move TCP state to tcp package and cleanup probe
TCP probe support is implemented, unnecessarily, across the stack and and tcp
packages. It can live entirely in tcp. Additionally, it is only ever set at
initialization time, so support for dynamically adding/removing the probe isn't
necesary.
The probe is getting in the way of adding debugging for b/339664055.