Load/Store, masked set and counting operations #2430
Merged
+384
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jan-wassenberg
requested changes
Jan 6, 2025
Rename SetOr* ops for consistency Rename AllOnes/AllZeros to AllBits1/0 Remove MaskedLoadU, this is covered by MaskedLoad Rename LowerHigher to InsertIntoUpper Rework StoreTruncated, rename to TruncateStore Rename macro arg Avoid full-length load in LoadHigher Optimise AllBits1
wbb-ccl
force-pushed
the
cc_up_set_load_store_count_operations
branch
from
c1f7768 to
6b90d90
Compare
jan-wassenberg
requested changes
Jan 30, 2025
jan-wassenberg
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces:
"OrZero" operations will return zero where the mask is false whereas standard masking returns the corresponding lane of a passed vector.
All introduced operations are implemented in generic_ops-inl.h and in arm_sve-inl.h where there is a performance gain to be made. Testing is also performed for all new operations.