Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change responsive to work better on Square devices #1791

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Change responsive to work better on Square devices #1791

merged 3 commits into from
Nov 6, 2023

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Nov 6, 2023

WHAT

Change responsive to work better on Square devices

WHY

No point having a larger top margin on full width square devices

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested a review from ssancho14 November 6, 2023 02:28
@yschimke yschimke requested a review from luizgrp November 6, 2023 23:40
@yschimke
Copy link
Collaborator Author

yschimke commented Nov 6, 2023

@luizgrp Can you post review?

@yschimke yschimke merged commit b5e6513 into google:main Nov 6, 2023
4 checks passed
luizgrp
luizgrp reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yschimke yschimke deleted the square branch November 13, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizgrp luizgrp luizgrp left review comments

@ssancho14 ssancho14 Awaiting requested review from ssancho14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @luizgrp