Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for responsive layout #1792

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Add a test for responsive layout #1792

merged 6 commits into from
Nov 6, 2023

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Nov 6, 2023

WHAT

Add a test for responsive layout.

WHY

Want to understand display issues.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested a review from ssancho14 November 6, 2023 02:57
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last chip truncation seems to be a result of robolectric/robolectric#8592

@yschimke yschimke marked this pull request as ready for review November 6, 2023 06:44
@yschimke yschimke requested a review from luizgrp November 6, 2023 23:38
@yschimke
Copy link
Collaborator Author

yschimke commented Nov 6, 2023

@luizgrp can you post review. Tests only. timezones!

@yschimke yschimke merged commit eea2991 into google:main Nov 6, 2023
4 checks passed
Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yschimke yschimke mentioned this pull request Nov 10, 2023
@yschimke yschimke deleted the add_test2 branch November 13, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants