Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datalayer-phone-ui library #1829

Closed
wants to merge 1 commit into from
Closed

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Nov 22, 2023

WHAT

Add datalayer-phone-ui library with Install App prompt feature.

Screen_recording_20231124_101908.mp4

HOW

  • Add datalayer-phone-ui module;
  • Add PhoneUiDataLayerHelper class as API entry point;
  • Add InstallAppDialog composable which is public and can also be used directly without the API;

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp self-assigned this Nov 22, 2023
@luizgrp luizgrp mentioned this pull request Nov 22, 2023
2 tasks
@luizgrp
Copy link
Member Author

luizgrp commented Jan 3, 2024

Closing it in favor of #1929

@luizgrp luizgrp closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants