Media button ripple fix #1842
Merged
Media button ripple fix #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Dec 4, 2023
| */ | ||
| @ExperimentalHorologistApi | ||
| @Composable | ||
| public fun UnboundedRippleButton( |
There was a problem hiding this comment.
Do we want this as new public API, or keep internal?
There was a problem hiding this comment.
We can keep it internal for now.
yschimke
reviewed
Dec 4, 2023
...ain/java/com/google/android/horologist/media/ui/components/controls/UnboundedRippleButton.kt
Show resolved
Hide resolved
yschimke
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Make the button click ripple in previous/next media buttons bigger and round.
WHY
Previously the button click ripple for media buttons was too small, and oval rather than round, which is bad UX.
HOW
Checklist 📋