Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve explanation of install prompt demo for Gmail #1964

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Improve explanation of install prompt demo for Gmail #1964

merged 3 commits into from
Jan 12, 2024

Conversation

kul3r4
Copy link
Collaborator

@kul3r4 kul3r4 commented Jan 12, 2024

WHAT

Improve explanation of install prompt demo for Gmail

WHY

Not clear what it does before running it

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@kul3r4 kul3r4 requested a review from luizgrp January 12, 2024 15:29
luizgrp
luizgrp approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@luizgrp luizgrp enabled auto-merge (squash) January 12, 2024 15:41
@luizgrp luizgrp merged commit 8c9c9e1 into google:main Jan 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizgrp luizgrp luizgrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kul3r4 @luizgrp