Add test for EdgeButton and IconButton padding in TransformingLazyColumn #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new test case to verify the correct padding behavior of `TransformingLazyColumn` when used with `EdgeButton` and `IconButton`. The test renders a `TransformingLazyColumn` with an `EdgeButton` and an `IconButton` and checks the top/bottom padding applied to the column content. Additionally, the test ensures that scrolling to the end of the column works as expected. Screenshots are updated to reflect the new test case.
BowerSteve
reviewed
Nov 8, 2024
...test/java/com/google/android/horologist/compose/layout/TransformingLazyColumnDefaultsTest.kt
Outdated
Show resolved
Hide resolved
BowerSteve
reviewed
Nov 8, 2024
...test/java/com/google/android/horologist/compose/layout/TransformingLazyColumnDefaultsTest.kt
Show resolved
Hide resolved
BowerSteve
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This commit adds a new test case to verify the correct padding behavior of
TransformingLazyColumnwhen used withEdgeButtonandIconButton. The test renders aTransformingLazyColumnwith anEdgeButtonand anIconButtonand checks the top/bottom padding applied to the column content. Additionally, the test ensures that scrolling to the end of the column works as expected.Screenshots are updated to reflect the new test case.
WHY
HOW
Checklist 📋