Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves modifier to the scaffold instead of the pager component. #2475

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Moves modifier to the scaffold instead of the pager component. #2475

merged 3 commits into from
Dec 6, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Dec 6, 2024

WHAT

Also the pageNestedScrollConnection parameter was redundant and has been removed from PagerScreen.

WHY

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke
Moves modifier to the scaffold instead of the pager component.
9393ad5 
Also the `pageNestedScrollConnection` parameter was redundant and has been removed from `PagerScreen`.
@yschimke yschimke requested a review from garanj December 6, 2024 09:26
@yschimke yschimke closed this Dec 6, 2024
@yschimke yschimke reopened this Dec 6, 2024
@yschimke yschimke merged commit 3400c2a into google:main Dec 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garanj garanj Awaiting requested review from garanj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yschimke