allow to write to PathURLConnection #160
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
we needed the ability to write to the PathURLConnection of jimfs for unit testing. The suggested change allowed us to use jimfs in the context of EMF (Eclipse Modeling Framework).
We are not sure about the contract of getOutputStream, but for usual sockets there seems to be one stream, which will be reused for subsequent calls to getOutputStream (e.g. AbstractPlainSocketImpl).
A "try with resource" usage of the stream, would then close the stream and the next call to getOutputStream would return the closed stream. In our case this was not relevant and it is aligned with the getInputStream behavior.
We have not opened the stream in the connect method, but only on demand in the getOutputStream method.
It would be good, if this functionality (or enhanced implementation) could be added to the library.
Thanks
Janik