Split Rust code between CLI and library #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invernizzi
reviewed
May 24, 2024
| labels.entry(target).or_default().push(label); | ||
| } | ||
| let labels = labels; | ||
| let mut output = File::create("../lib/src/label.rs")?; |
There was a problem hiding this comment.
Could you add a comment explaining why dynamically generating this file is necessary (or add it to the README.md of this directory)?
There was a problem hiding this comment.
please add a line mentioning that this is generated by the gen crate. It should help code wanderers to figure things out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use the latest release candidate of the ORT library, which provides async inference. The CLI now creates only one session and shares it between the different inference tasks.
This also implements the features extraction reference tests.