Add wait and progress options to Viewer.switchScene #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wait: Delays transitioning to the new scene until all visible tiles are loaded. If the user rotates the camera while loading, it may take longer to load. progress: Calls a function as progress loading visible tiles is made. can be used with or without wait. Progress values are given in the range of [0..1] and may go down if the user rotates the camera, bringing new tiles into view.
When switching to another scene while already waiting for a scene to load, remove the previous monitoring events and layers of the previously requested scene.
trevorparscal
changed the title
|
@tjgq could you please look into this, seems like an excellent addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait: Allows optionally waiting until visible tiles are loaded before transitioning.
progress: Allow optionally providing a callback which is executed with progress values as visible tiles are loaded