Install Mozc into %ProgramFiles%\Mozc rather than %ProgramFiles(x86)%\Mozc
#1086
Assignees
Comments
yukawa
added a commit
to yukawa/mozc
that referenced
this issue
Oct 17, 2024
This is a preparation to switch Mozc's installation directory from %ProgramFiles(x86)%\Mozc into %ProgramFiles%\Mozc without user observable downtime (google#1086). Currently the directory %ProgramFiles(x86)%\Mozc is effectively hard coded in 'mozc_tip{32,64}.dll'. This means if older versions of 'mozc_tip{32,64}.dll' continue assuming the previous installation directory until it is unloaded or the process is restarted. To avoid such mismatch, with this commit SystemUtil::GetServerDirectory() starts dynamically retrieving Mozc's installation directory from registry by checking COM entries of 'mozc_tip64.dll'. If it fails, we fall back to the previous behavior. Note that this is the first step of the migration and we cannot go to the next step until 'mozc_tip{32,64}.dll' with this commit is deployed to users.
yukawa
added a commit
to yukawa/mozc
that referenced
this issue
Oct 17, 2024
This is a preparation to switch Mozc's installation directory from %ProgramFiles(x86)%\Mozc into %ProgramFiles%\Mozc without user observable downtime (google#1086). Currently the directory %ProgramFiles(x86)%\Mozc is effectively hard coded in 'mozc_tip{32,64}.dll'. This means if older versions of 'mozc_tip{32,64}.dll' continue assuming the previous installation directory until it is unloaded or the process is restarted. To avoid such mismatch, with this commit SystemUtil::GetServerDirectory() starts dynamically retrieving Mozc's installation directory from registry by checking COM entries of 'mozc_tip64.dll'. If it fails, we fall back to the previous behavior. Note that this is the first step of the migration and we cannot go to the next step until 'mozc_tip{32,64}.dll' with this commit is deployed to users.
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Oct 21, 2024
This is a preparation to switch Mozc's installation directory from %ProgramFiles(x86)%\Mozc into %ProgramFiles%\Mozc without user observable downtime (#1086). Currently the directory %ProgramFiles(x86)%\Mozc is effectively hard coded in 'mozc_tip{32,64}.dll'. This means if older versions of 'mozc_tip{32,64}.dll' continue assuming the previous installation directory until it is unloaded or the process is restarted. To avoid such mismatch, with this commit SystemUtil::GetServerDirectory() starts dynamically retrieving Mozc's installation directory from registry by checking COM entries of 'mozc_tip64.dll'. If it fails, we fall back to the previous behavior. Note that this is the first step of the migration and we cannot go to the next step until 'mozc_tip{32,64}.dll' with this commit is deployed to users. PiperOrigin-RevId: 688083089
yukawa
added a commit
to yukawa/mozc
that referenced
this issue
Dec 3, 2024
The current implementation of ProgramFilesX86Cache::TryProgramFilesPath is unnecessarily complex. We can always use CSIDL_PROGRAM_FILESX86 not only within 64-bit processes but also within 32-bit processes. There must be no observable behavior change in this commit. This is a preparation to build Mozc as an ARM64 executable (google#1130). See google#1086 for how and when we can stop relying on this historical installation location.
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Dec 4, 2024
The current implementation of ProgramFilesX86Cache::TryProgramFilesPath is unnecessarily complex. We can always use CSIDL_PROGRAM_FILESX86 not only within 64-bit processes but also within 32-bit processes. There must be no observable behavior change in this commit. This is a preparation to build Mozc as an ARM64 executable (#1130). See #1086 for how and when we can stop relying on this historical installation location. PiperOrigin-RevId: 702632385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Historically we have been installing Mozc into
%ProgramFiles(x86)%\Mozc(e.g.C:\Program Files (x86)\Mozc) rather than%ProgramFiles%\Mozceven on 64-bint environment as that is how Google Japanese Input has been doing since 2009.This is going to be much more confusing when we start supporting Windows Arm64 environment, where we may see the following 3 "Program Files" directories.
C:\Program Files: 64-bit binaries for both Arm64 and x86_64C:\Program Files (Arm): arm 32-bit binariesC:\Program Files (x86): x86 32-bit binariesLet's see if we can migrate from
%ProgramFiles(x86)%\Mozcto%ProgramFiles%\Mozcwithout disturbing existing (Google Japanese Input) users, as one of preparations to support Windows Arm64 environments.Steps to reproduce
Steps to reproduce the behavior:
%ProgramFiles(x86)%\Mozc.%ProgramFiles%\Mozc.msiexec.exe /i Mozc64.msi /qn REBOOT=ReallySuppressScreenshots
Mozc continues working on the app launched at the step 2.
Version or commit-id
8c8a446
Environment
Additional context
The text was updated successfully, but these errors were encountered: