Simplify ProgramFilesX86Cache::TryProgramFilesPath
#1131
Merged
+3
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of ProgramFilesX86Cache::TryProgramFilesPath is unnecessarily complex. We can always use CSIDL_PROGRAM_FILESX86 not only within 64-bit processes but also within 32-bit processes. There must be no observable behavior change in this commit. This is a preparation to build Mozc as an ARM64 executable (google#1130). See google#1086 for how and when we can stop relying on this historical installation location.
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of
ProgramFilesX86Cache::TryProgramFilesPathis unnecessarily complex. We can always useCSIDL_PROGRAM_FILESX86not only within 64-bit processes but also within 32-bit processes.There must be no observable behavior change in this commit.
This is a preparation to build Mozc as an ARM64 executable (#1130).
Issue IDs
%ProgramFiles%\Mozcrather than%ProgramFiles(x86)%\Mozc#1086Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).
Mozc64.msi