Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Bazel 8.0 #1118

Closed
yukawa opened this issue Nov 5, 2024 · 1 comment · Fixed by #1154
Closed

Migrate to Bazel 8.0 #1118

yukawa opened this issue Nov 5, 2024 · 1 comment · Fixed by #1154
Assignees
@yukawa

Comments

@yukawa
Copy link
Collaborator

yukawa commented Nov 5, 2024 •
edited
Loading

Description

As Bazel 8.0 is expected to be released in late November 2024, it's time for us to start preparing for the transition from Bazel 7.4.x to Bazel 8.0.x.

Tasks

  • Pin Bazel version to Bazel 7.4.x until we Mozc becomes fully compatible with Bazel 8.0
    • For GitHub Actions where Bazelisk is actually used, we can rely on USE_BAZEL_VERSION to specify the Bazel version.
  • Make sure all the dependent Bazel modules are compatible with Bazel 8.0
    • Update module versions as needed.
  • Make sure Mozc's own build rules are compatible with Bazel 8.0
    • Update Mozc's own build rules as needed.
  • Once Mozc becomes fully compatible with Bazel 8.0, drop Bazel 7.x support.

Version or commit-id

e1b40ed
@yukawa yukawa pinned this issue Nov 5, 2024
yukawa added a commit to yukawa/mozc that referenced this issue Nov 18, 2024
@yukawa
Clarify Bazel 8.0 is not yet supported (google#1118)
d236037 
As Mozc is not compatible with Bazel 8.0 yet, let's

 * pin Bazel version to Bazel 7.4.1 in GitHub Actions.
 * clarify that Bazel 8.0 is not supported in the build instructions.
yukawa added a commit to yukawa/mozc that referenced this issue Nov 18, 2024
@yukawa
Clarify Bazel 8.0 is not yet supported (google#1118)
a00369e 
As Mozc is not compatible with Bazel 8.0 yet, let's

 * pin Bazel version to Bazel 7.4.1 in GitHub Actions.
 * clarify that Bazel 8.0 is not supported in the build instructions.
@yukawa yukawa mentioned this issue Nov 18, 2024
Merged
hiroyuki-komatsu pushed a commit that referenced this issue Nov 20, 2024
@yukawa
Clarify Bazel 8.0 is not yet supported (#1118) (#1123)
2016df9 
As Mozc is not compatible with Bazel 8.0 yet, let's

 * pin Bazel version to Bazel 7.4.1 in GitHub Actions.
 * clarify that Bazel 8.0 is not supported in the build instructions.

PiperOrigin-RevId: 698388242
@yukawa yukawa mentioned this issue Dec 16, 2024
Closed
wengxt added a commit to fcitx/mozc that referenced this issue Dec 18, 2024
@wengxt
Add bazel 8 support to pkg_config_repository() (google#1118)
7aa509a 
bazel have --incompatible_disallow_empty_glob default to True. For
pkg-config repository, libexec is likely to be empty, while hdrs should
always contain some header files.
wengxt added a commit to fcitx/mozc that referenced this issue Dec 18, 2024
@wengxt
Add bazel 8 support to pkg_config_repository() (google#1118)
0f24556 
bazel 8 set --incompatible_disallow_empty_glob default to True. For
pkg-confg repository, libexec is likely to be empty, so empty should be
allowed there.
@wengxt
Copy link
Contributor

wengxt commented Dec 18, 2024

Just FYI that with rules_apple bumped to 3.16.1 (I'm not sure if a minimum working version preferred but I just tried the latest one) & #1144 , I'm able to build a usable server & gui tool & fcitx5 support on linux.

@yukawa yukawa mentioned this issue Dec 18, 2024
Closed
hiroyuki-komatsu pushed a commit that referenced this issue Dec 18, 2024
@wengxt
Add bazel 8 support to pkg_config_repository() (#1118) (#1144)
4c7f048 
bazel 8 set --incompatible_disallow_empty_glob default to True. For
pkg-confg repository, libexec is likely to be empty, so empty should be
allowed there.

PiperOrigin-RevId: 707430069
@yukawa yukawa mentioned this issue Dec 19, 2024
Closed
yukawa added a commit to yukawa/mozc that referenced this issue Dec 24, 2024
@yukawa
Switch to Bazel 8.0.0
de99f7b 
With this commit we fully switch to Bazel 8.0.0 as the officially
supported build environment for Mozc.

Closes google#1118.
@yukawa yukawa mentioned this issue Dec 24, 2024
Merged
@yukawa yukawa self-assigned this Dec 24, 2024
yukawa added a commit to yukawa/mozc that referenced this issue Dec 24, 2024
@yukawa
Switch to Bazel 8.0.0
4f074c7 
With this commit we fully switch to Bazel 8.0.0 as the officially
supported build environment for Mozc.

Closes google#1118.
hiroyuki-komatsu pushed a commit that referenced this issue Dec 26, 2024
@yukawa
Switch to Bazel 8.0.0 (#1154)
6dadef1 
With this commit we fully switch to Bazel 8.0.0 as the officially
supported build environment for Mozc.

Closes #1118.

PiperOrigin-RevId: 709793147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yukawa yukawa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to Bazel 8.0.0 yukawa/mozc
2 participants
@wengxt @yukawa