-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conform Per-Monitor DPI v2 protocol in Windows #831
Comments
This was referenced Oct 21, 2023
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Oct 23, 2023
With this commit macOS and Windows builds switch to Qt 6.6.0 [1], which contains an important commit for Per-Monitor DPI support in Windows [2] as discussed in #831. Note that '-no-feature-systemsemaphore' needs to be removed as otherwise the build fails in macOS. [1]: https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/6.6.0/release-note.md [2]: qt/qtbase@5e0d9a0 PiperOrigin-RevId: 575700086
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Oct 23, 2023
This is part of our on-going effort to make Mozc binaries comply with Per Monitor DPI V2 protocol in Windows (#831). With this commit, 'mozc_renderer' process starts running under Per Monitor DPI V2 mode, and Qt 6.6 also correctly recognizes it at run time [1]. [1]: qt/qtbase@5e0d9a0 PiperOrigin-RevId: 575708085
coooooooozy
pushed a commit
to coooooooozy/mozc
that referenced
this issue
Nov 26, 2023
This is a minimum change to place candidate windows around the cursor location even under Per-Monitor DPI mode in Windows. Note that there are still known issues that 'mozc_render' continues using the initial DPI. Watch google#831 for such remaining issues. Closes google#832. PiperOrigin-RevId: 575633393
coooooooozy
pushed a commit
to coooooooozy/mozc
that referenced
this issue
Nov 26, 2023
With this commit macOS and Windows builds switch to Qt 6.6.0 [1], which contains an important commit for Per-Monitor DPI support in Windows [2] as discussed in google#831. Note that '-no-feature-systemsemaphore' needs to be removed as otherwise the build fails in macOS. [1]: https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/6.6.0/release-note.md [2]: qt/qtbase@5e0d9a0 PiperOrigin-RevId: 575700086
coooooooozy
pushed a commit
to coooooooozy/mozc
that referenced
this issue
Nov 26, 2023
This is part of our on-going effort to make Mozc binaries comply with Per Monitor DPI V2 protocol in Windows (google#831). With this commit, 'mozc_renderer' process starts running under Per Monitor DPI V2 mode, and Qt 6.6 also correctly recognizes it at run time [1]. [1]: qt/qtbase@5e0d9a0 PiperOrigin-RevId: 575708085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Currently Mozc binaries fall into System DPI Awareness category in Windows.
We'd like to make them run under Per-Monitor v2 Awareness mode.
Version or commit-id
af20906
Environment
Additional Context
src/gui/tool/mozc_tool.exe.manifest
mozc/src/gui/tool/mozc_tool.exe.manifest
Lines 25 to 27 in af20906
Needs
PerMonitorV2
declaration.Also, it'd be safer to switch to Qt 6.6 or later version, which contains qt/qtbase@5e0d9a0.
src/renderer/win32/mozc_renderer.exe.manifest
mozc/src/renderer/win32/mozc_renderer.exe.manifest
Lines 25 to 27 in af20906
Needs
PerMonitorV2
declaration.src/renderer/win32/indicator_window.cc
mozc/src/renderer/win32/indicator_window.cc
Lines 96 to 100 in af20906
We can no longer assume this is a runtime constant.
mozc/src/renderer/win32/indicator_window.cc
Lines 115 to 119 in af20906
We also need to handle WM_DPICHANGED.
src/renderer/win32/candidate_window.h
mozc/src/renderer/win32/candidate_window.h
Lines 77 to 88 in af20906
We also need to handle WM_DPICHANGED.
src/renderer/win32/candidate_window.cc
mozc/src/renderer/win32/candidate_window.cc
Lines 234 to 265 in af20906
scale_factor_x
andscale_factor_y
are no longer the runtime constants. We need to re-calculate these values every time WM_DPICHANGED is received.src/win32/tip/tip_lang_bar_menu.cc
LoadIconFromResource
should useGetSystemMetricsForDpi
with primary display's DPI no matter which display is used to show the application, because the IME mode icon is shown only on the primary display.mozc/src/win32/tip/tip_lang_bar_menu.cc
Lines 105 to 119 in af20906
The text was updated successfully, but these errors were encountered: