Remove obsolete build options from .bazelrc
#1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we successfully merged PR #1116, we can close this PR. |
This commit removes the following bazel options that were originally added [1] to support bzlmod for Android (google#1002). - experimental_enable_android_migration_apis - experimental_google_legacy_api As far as we can see with Bazel 7.4.0, building Mozc with Bazel just succeeds without the above two options in all the supported platforms. Closes google#1117. [1]: 699c2ce
@hiroyuki-komatsu, I believe it'd still make sense to remove the following two options even after #1116.
Can you take another look? |
|
That's right. We have merged this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit removes the following bazel options that were originally 699c2ce to support bzlmod for Android (#1002).
experimental_enable_android_migration_apisexperimental_google_legacy_apiAs far as we can see with Bazel 7.4.0, building Mozc with Bazel just succeeds without the above two options in all the supported platforms.
Closes #1117.
Issue IDs
--experimental_google_legacy_apior not #1117Steps to test new behaviors (if any)