Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Android 14 #1856

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Update to Android 14 #1856

merged 4 commits into from
Oct 11, 2023

Conversation

robertwu1
Copy link
Collaborator

Fixes #1855

@robertwu1 robertwu1 requested a review from philburk July 12, 2023 23:22
@robertwu1 robertwu1 changed the title Update to android 14 Update to Android 14 Oct 4, 2023
philburk
philburk approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that "Android API 34" is showing up in the Android Studio SDK Manager.

philburk
philburk requested changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing with:
/home/runner/work/oboe/oboe/apps/OboeTester/app/src/main/java/com/mobileer/oboetester/TestColdStartLatencyActivity.java:188: error: getDeviceId() in TestColdStartLatencyActivity cannot override getDeviceId() in ContextWrapper
private native int getDeviceId();
^
attempting to assign weaker access privileges; was public
Note: Some input files use or override a deprecated API.

Which is odd because that file was not touched.

@philburk
Copy link
Collaborator

philburk commented Oct 6, 2023

Android 14 must have added getDeviceId() to ContextWrapper!

@philburk
Copy link
Collaborator

philburk commented Oct 6, 2023 •
edited
Loading

Yep!
https://developer.android.com/reference/android/content/ContextWrapper#getDeviceId()

Maybe change it to getAudioDeviceId() to avoid the collision.

@robertwu1
Copy link
Collaborator Author

Fixed! Thanks for catching this!

@robertwu1 robertwu1 merged commit 0f0d8b1 into main Oct 11, 2023
3 checks passed
@robertwu1 robertwu1 deleted the robertwu/updatetoandroid14 branch October 11, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philburk philburk philburk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update apps, samples, and tests to Android 14
2 participants
@robertwu1 @philburk