Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OboeTester: Change action bar to light #2048

Merged
merged 4 commits into from
Jun 28, 2024
Merged

OboeTester: Change action bar to light #2048

merged 4 commits into from
Jun 28, 2024

Conversation

robertwu1
Copy link
Collaborator

@robertwu1 robertwu1 commented Jun 26, 2024 •
edited
Loading

OboeTester had always used a light action bar until #2019. That PR changed the action bar to a dark theme. This PR changes action bars back to light.

@robertwu1 robertwu1 requested a review from philburk June 26, 2024 18:45
philburk
philburk requested changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should stick to portrait because the tests do not handle rotation properly.

@robertwu1 robertwu1 requested a review from philburk June 27, 2024 22:20
@robertwu1 robertwu1 changed the title OboeTester: Change action bar to light and allow landscape OboeTester: Change action bar to light Jun 27, 2024
@robertwu1 robertwu1 merged commit 863a586 into main Jun 28, 2024
3 checks passed
@robertwu1 robertwu1 deleted the robertwu/whiteactionbar branch June 28, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philburk philburk philburk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertwu1 @philburk