AdpfWrapper: Add trace for actualDurationNanos #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertwu1
commented
Jan 29, 2025
philburk
requested changes
Feb 7, 2025
|
|
||
| if (ATrace_beginSection != nullptr && ATrace_endSection != nullptr){ | ||
| mIsTracingSupported = true; | ||
| if (ATrace_beginSection != nullptr && ATrace_endSection != nullptr && ATrace_isEnabled != nullptr && ATrace_isEnabled()){ |
| static void beginSection(const char *format, ...); | ||
| static void endSection(); | ||
| static void initialize(); | ||
| namespace oboe { |
There was a problem hiding this comment.
Add short comment about being a wrapper for tracing for use with Perfetto.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ATrace, we can profile the time between callbacks for the workload. Perfetto provides a nice UI to see this callback time in comparison to other metrics like CPU usage and the ADPF session batch size.
Instructions:
adb shell -t perfetto audio sched freq power hal idle binder_driver ss --time 20s --out /data/misc/perfetto-traces/test123.pf --app com.mobileer.oboetesteradb pull /data/misc/perfetto-traces/test123.pf localfile.pfNote that ATrace_setCounter() is only supported on Android level 29 and above and ATrace_isEnabled() is enabled only when the perfetto command is run from adb shell.