Fix Dart2 runtime errors in tests

Fixes #67
google · May 3, 2018 · 1174dec · 1174dec
1 parent ecfc06d
commit 1174dec
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.22.1+1
+
+* Fixes for Dart2 runtime type errors.
+
 ## 0.22.1
 
 * Added `ObservableList.castFrom`, similar to `List.castFrom`.

diff --git a/lib/src/observable_list.dart b/lib/src/observable_list.dart
@@ -303,7 +303,7 @@ class ObservableList<E> extends ListBase<E> with Observable {
 
   void _notifyListChange(
     int index, {
-    List<E> removed: const [],
+    List<E> removed,
     int addedCount: 0,
   }) {
     if (!hasListObservers) return;

diff --git a/lib/src/records/list_change_record.dart b/lib/src/records/list_change_record.dart
@@ -27,15 +27,16 @@ class ListChangeRecord<E> implements ChangeRecord {
   factory ListChangeRecord(
     List<E> object,
     int index, {
-    List<E> removed: const [],
+    List<E> removed,
     int addedCount: 0,
   }) {
-    return new ListChangeRecord._(object, index, removed, addedCount);
+    return new ListChangeRecord._(
+        object, index, removed ?? new UnmodifiableListView([]), addedCount);
   }
 
   /// Records an `add` operation at `object[index]` of [addedCount] elements.
   ListChangeRecord.add(this.object, this.index, this.addedCount)
-      : removed = const [] {
+      : removed = new UnmodifiableListView([]) {
     _assertValidState();
   }
 

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: observable
-version: 0.22.1
+version: 0.22.1+1
 author: Dart Team <[email protected]>
 description: Support for marking objects as observable
 homepage: https://github.com/dart-lang/observable