-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use OpenSSL 3.2.3 #12729
base: master
Are you sure you want to change the base?
use OpenSSL 3.2.3 #12729
Conversation
alandekok is a new contributor to projects/freeradius. The PR must be approved by known contributors before it can be merged. The past contributors are: mrw42, arr2036, catenacyber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dropped support for OpenSSL 1.1.1g so this looks correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No other comments
I've left an approving review, but merging is still blocked. |
projects/freeradius/Dockerfile
Outdated
@@ -15,17 +15,22 @@ | |||
################################################################################ | |||
|
|||
FROM gcr.io/oss-fuzz-base/base-builder | |||
|
|||
# Run update a first time to get latest package definitions | |||
RUN apt-get update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's usually better to do this in the same step you are doing apt-get install. Otherwise caching can bite you because this layer can be much older than the install layer, causing it to fail.
Head branch was pushed to by a user without write access
The main FreeRADIUS branch does not allow OpenSSL 1.x any more. So we upgrade to 3.2.3.