Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use OpenSSL 3.2.3 #12729

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

use OpenSSL 3.2.3 #12729

wants to merge 10 commits into from

Conversation

alandekok
Copy link

The main FreeRADIUS branch does not allow OpenSSL 1.x any more. So we upgrade to 3.2.3.

Copy link

alandekok is a new contributor to projects/freeradius. The PR must be approved by known contributors before it can be merged. The past contributors are: mrw42, arr2036, catenacyber

Copy link
Contributor

@arr2036 arr2036 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dropped support for OpenSSL 1.1.1g so this looks correct

Copy link
Contributor

@arr2036 arr2036 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other comments

@arr2036
Copy link
Contributor

arr2036 commented Nov 18, 2024

I've left an approving review, but merging is still blocked.

@@ -15,17 +15,22 @@
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder

# Run update a first time to get latest package definitions
RUN apt-get update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's usually better to do this in the same step you are doing apt-get install. Otherwise caching can bite you because this layer can be much older than the install layer, causing it to fail.

@jonathanmetzman jonathanmetzman enabled auto-merge (squash) November 18, 2024 17:11
auto-merge was automatically disabled November 18, 2024 17:29

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants