-
Notifications
You must be signed in to change notification settings - Fork 2.3k
libgit2: Fix build #13202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
libgit2: Fix build #13202
Conversation
Commit fb59acb24652383baf46744892058a044d12724f (libgit2) introduced the USE_AUTH_NTLM flag, which causes a dependency not to be built.
marcellomaugeri is a new contributor to projects/libgit2. The PR must be approved by known contributors before it can be merged. The past contributors are: fanquake, DonggeLiu, devtty1er, Dor1s, nelhage (unverified), pks-t (unverified) |
The builds work on my machine, but I suspect the build failures are due to an architecture mismatch (I use an ARM Mac, and I could see that some of the build images are defaulting to ARM). |
Now the build works, except for the (none, address, x86_64) as it is looking for $LIB_FUZZING_ENGINE which is missing. I could not run the fuzzer though, it gives a memory allocation error (probably due to the emulation? I have to try in a native amd64 machine), I will investigate more next week. |
c3efd44
to
6f8b783
Compare
Before updating to the last branch, it passed all the checks, so I assume it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcellomaugeri could you get some of the maintainers from libgit2 to help review this one? It would be great to get their confirmation
Commit fb59acb24652383baf46744892058a044d12724f (libgit2) introduced the USE_AUTH_NTLM flag, which causes a dependency not to be built.