Fixed Issue #1555 #1557
Open
Fixed Issue #1555 #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Added a global variable servePort with a default value of "8000" 2.Added a new CLI flag --port that allows users to customize the port number used when serving the HTML report 3. Removed the hardcoded port number from the ServeHTML function, using the global servePort variable instead 4. The flag's Action function updates the global servePort variable when a custom port is specified These changes allow users to specify a custom port using the --port flag when using the --serve option, while maintaining the default port 8000 if no custom port is specified.
…xed_issue_#1555 fixed issue google#1555
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@jtt @abhisek @calebbrown @iurisilvio Can anyone of you review my PR? I have also just signed the Google CLA. Excited to begin contributing to this repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes are in file osv-scanner/cmd/osv-scanner/internal/helper/helper.go
1.Added a global variable servePort with a default value of "8000"
2.Added a new CLI flag --port that allows users to customize the port number used when serving the HTML report
3.Removed the hardcoded port number from the ServeHTML function, using the global servePort variable instead
These changes allow users to specify a custom port using the --port flag when using the --serve option, while maintaining the default port 8000 if no custom port is specified.