Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make skip git the default behavior #1584

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

another-rex
Copy link
Collaborator

@another-rex another-rex commented Feb 7, 2025

Also removes the --json flag since that has been deprecated for a while now. The json tests are not deleted, as there are the same tests with the --format json flag.

Succeeds: #1311
Closes: #1277

Also remove --json flag as that has been deprecated for a long time now.
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.31%. Comparing base (5d9ea86) to head (f2ae862).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
+ Coverage   69.30%   69.31%   +0.01%     
==========================================
  Files         200      200              
  Lines       19034    19033       -1     
==========================================
+ Hits        13191    13193       +2     
+ Misses       5135     5133       -2     
+ Partials      708      707       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cuixq cuixq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update docs about this behavior change? (not sure if skipping git is documented...)

@another-rex
Copy link
Collaborator Author

Good point, I'll add the new flags to the docs.

@another-rex another-rex requested a review from cuixq February 7, 2025 05:14
@another-rex another-rex merged commit fd2ef0f into google:main Feb 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making "skip git" the default in v2
3 participants