Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "refactor: use pomxmlnet extractor from scalibr" #1613

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Feb 12, 2025

Reverts #1586

We don't want this in v2.0.0-beta2

@cuixq cuixq changed the title Revert "refactor: use pomxmlnet extractor from scalibr" chore: Revert "refactor: use pomxmlnet extractor from scalibr" Feb 12, 2025
@another-rex another-rex enabled auto-merge (squash) February 12, 2025 04:47
@another-rex another-rex merged commit f9bcb9c into main Feb 12, 2025
16 of 17 checks passed
@another-rex another-rex deleted the revert-1586-pomxml branch February 12, 2025 04:48
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 75.75758% with 32 lines in your changes missing coverage. Please review.

Project coverage is 69.33%. Comparing base (6ecc827) to head (5ebd981).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...calibrextract/language/java/pomxmlnet/extractor.go 73.98% 27 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1613      +/-   ##
==========================================
+ Coverage   68.97%   69.33%   +0.35%     
==========================================
  Files         199      200       +1     
  Lines       18922    19042     +120     
==========================================
+ Hits        13052    13202     +150     
+ Misses       5177     5134      -43     
- Partials      693      706      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants