Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature for Displaying Commands in User Provided Order #298 #310

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

shubhamdo
Copy link

Generated #298 Feature.
Description of the feature:
Fire displays commands in alphabetical order, this feature allows user to show them in a custom order specified by the user.

@varunjohn786

varunjohn786 and others added 8 commits January 8, 2021 15:32
updated code to add functionality to reorder commands.
add help sequence functionality in _PrintResult function.
Updated logic of the code so that description of command doesn't affect the order sequence
Updated core.py file, so that _DisplayError function also shows reordered commands.
1. Added Docstrings
2. Test Case
3. Test Components
@google-cla
Copy link

google-cla bot commented Jan 21, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Author has not signed CLA label Jan 21, 2021
fire/core.py Outdated Show resolved Hide resolved
Updated core.py file to correct mistake in UsageText() function call.
@google-cla
Copy link

google-cla bot commented Feb 28, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@varunjohn786
Copy link

@googlebot I signed it!

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Feb 28, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes Author has signed CLA and removed cla: no Author has not signed CLA labels Feb 28, 2021
@dbieber
Copy link
Member

dbieber commented Dec 9, 2022

Thanks for the PR! (And for your patience!) However, we don't have plans to add this feature at this time.
I apologize for the lengthy delay in providing this response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants