Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github action #5

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Add Github action #5

merged 1 commit into from
Jan 13, 2023

Conversation

1c3t3a
Copy link
Collaborator

@1c3t3a 1c3t3a commented Oct 17, 2022

This change adds a GH action that checks formatting and runs cargo clippy as well as the current test suite.

@1c3t3a 1c3t3a requested a review from rcvalle October 17, 2022 12:07
@8573
Copy link

8573 commented Oct 17, 2022

Maybe the permissions given to actions-rs/clippy-check could be restricted as in actions-rs/clippy-check#166 rather than giving the full GITHUB_TOKEN, which has needlessly broad permissions?

@rcvalle
Copy link
Collaborator

rcvalle commented Oct 21, 2022

Maybe the permissions given to actions-rs/clippy-check could be restricted as in actions-rs/clippy-check#166 rather than giving the full GITHUB_TOKEN, which has needlessly broad permissions?

* [GitHub Actions needed for in Nixpkgs NixOS/nixpkgs#104594 (comment)](https://github.com/NixOS/nixpkgs/issues/104594#issuecomment-731828681)

* [Should the README comment on risks (if any) of using 3rd-party GitHub Actions? rustsec/rustsec#303](https://github.com/rustsec/rustsec/issues/303)

Thank you for pointing this out, @8573! We'll look into this.

@rcvalle
Copy link
Collaborator

rcvalle commented Oct 21, 2022

FYI, I'm taking longer on this PR because I want to add a few more workflows, so I'll probably send a PR to your branch so we can add it all on this PR.

@1c3t3a 1c3t3a force-pushed the add-gh-actions branch 9 times, most recently from ad777da to 519763a Compare November 28, 2022 12:41
@1c3t3a
Copy link
Collaborator Author

1c3t3a commented Nov 28, 2022

@rcvalle I added an action to publish the crate as well :) I also tested all the actions, the executed runs can be found in my forked repository.

@1c3t3a 1c3t3a force-pushed the add-gh-actions branch 2 times, most recently from 53d57ad to d957b4e Compare December 13, 2022 09:02
@1c3t3a 1c3t3a requested a review from rcvalle December 25, 2022 16:37
@rcvalle rcvalle merged commit d49f6a9 into google:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants