Add support to HyperSQL weak credentials tester #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| 5. SECURED: Run the docker build: `cd hsqldb_secured && docker build . -t hsqldb_secured && docker run -d -p 8081:9001 --name hsqldb_secured hsqldb_secured && cd ..` | ||
|
|
||
| 6. Connect to it locally by using hsqldb.jar and sqltool.jar with command `java -cp hsqldb-2.7.2.jar:sqltool.jar org.hsqldb.cmdline.SqlTool --inlineRc=url=jdbc:hsqldb:hsql://localhost:8081/testdb,user=SA` and using password `securedpassword` |
There was a problem hiding this comment.
Hello @GiuseppePorcu, thanks for your contribution!
Testbed is fine, however step 6 can be improved by providing a command equivalent to the one in step 5, along with an alternative to verify whether a password has effectively been set.
Suggested change
| 6. Connect to it locally by using hsqldb.jar and sqltool.jar with command `java -cp hsqldb-2.7.2.jar:sqltool.jar org.hsqldb.cmdline.SqlTool --inlineRc=url=jdbc:hsqldb:hsql://localhost:8081/testdb,user=SA` and using password `securedpassword` | |
| 6. Connect to it locally using `hsqldb.jar` and `sqltool.jar` as follows: | |
| `java -cp hsqldb-2.7.2.jar:sqltool.jar org.hsqldb.cmdline.SqlTool --inlineRc=url=jdbc:hsqldb:hsql://localhost:8081/testdb,user=SA,password=` | |
| The above command will not log in successfully with an empty password, as expected. To authenticate properly, remove the password parameter and enter the correct password `securedpassword` when prompted. The final working command is: | |
| `echo -n securedpassword | java -cp hsqldb-2.7.2.jar:sqltool.jar org.hsqldb.cmdline.SqlTool --inlineRc=url=jdbc:hsqldb:hsql://localhost:8081/testdb,user=SA` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added testbed for the HyperSQL weak credentials.
Regards,