Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committing and going to sleep because I'm tired and the gradle chose … #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meredithb104
Copy link

…violence. Notes posted, found where override scripts are and where the events are tracked and where the advanced_preferences.xml will come in handy.

…violence. Notes posted, found where override scripts are and where the events are tracked and where the advanced_preferences.xml will come in handy.
@google-cla
Copy link

google-cla bot commented Apr 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@PatrykMis
Copy link

PatrykMis commented Nov 27, 2023

Hi @meredithb104,

I appreciate your work on this pull request! The program appears to be running, compiling and being imported to Android Studio smoothly without these changes. Could you please provide some insights into the goals of this PR? I'm curious about the specific modifications and the intended benefits. It would help us understand the context better.

What about these commented out and noted overrides?

Given the official nature of the TalkBack repository, it would be great to have more formal insights into the modifications.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants