Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade project's build-time dependencies #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jozuasijsling-ing
Copy link

@jozuasijsling-ing jozuasijsling-ing commented May 8, 2024

Let's upgrade tooling so that developers with recent Android Studio versions can build the project out of the box.

  • Upgraded AGP (Android Gradle Plugin) to 8.4.0
  • Embedded Gradle wrapper version 8.7
    AGP 8.4.0 needs at least Gradle 8.6, while Android Studio Jellyfish (current latest stable) ships with Gradle 8.4
  • Changed root module's compileSdk version to 34
    making it the same as the library modules
  • Disabled Jetifier
    as it is not needed according to ./gradlew checkJetifier
  • Removed multiDexEnabled instruction
    as it is enabled by default
  • Removed unused module :uiunderstanding
  • Removed unused plugin declaration for aspectjtools
  • Reworked build.sh , so that it…
    • …works even when started from another directory
    • …uses Gradle wrapper for downloading the Gradle binary
    • …relies on AGP for detecting and reporting missing environment variables

@jozuasijsling-ing jozuasijsling-ing force-pushed the jozuasijsling/upgrade-build-tooling branch 4 times, most recently from 3de3ab9 to c2cd2dd Compare May 8, 2024 17:39
Upgraded AGP (Android Gradle Plugin) to 8.4.0.
Removed unused aspectjtools plugin declaration.
…checking, relying instead on Gradle wrapper and AGP for detecting and reporting such issues.
@jozuasijsling-ing jozuasijsling-ing force-pushed the jozuasijsling/upgrade-build-tooling branch from 40ff4b6 to 8abbb8e Compare May 8, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants