Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

add "problems=problems" as an argument of schedule.Validate (). #480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kuwayamamasayuki
Copy link

@kuwayamamasayuki kuwayamamasayuki commented May 5, 2019

I wrote an extension. At that time, I implemented my own Schedule class in the form of inheriting transitfeed.Schedule.

Then, some warnings were output to the console instead of the HTML file.

The causes of such events are as follows.
In line 592 of feedvalidator.py, schedule.Validate () does not pass the "problems" variable as an argument, so "problems = self.problem_reporter" is executed at line 1336 of the called schedule.py , "problems" variable had been overwritten.

Therefore, I propose to add "problems=problems" as an argument of schedule.Validate ().

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kuwayamamasayuki
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jarondl
Copy link
Contributor

jarondl commented Oct 10, 2019

Thank you! this looks correct.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants