Add CI action that reports clang-tidy warnings as review comments. #1658
Conversation
hzeller
force-pushed
the
feature-20241010-run-clang-tidy-review
branch
6 times, most recently
from
400322a
to
7295f9c
Compare
|
@proppy I am trying to get this (Note, currently the action is https://github.com/hzeller/clang-tidy-pr-comments which is just a fork from the original https://github.com/platisd/clang-tidy-pr-comments for easier debugging). |
#xls-build-gardener
hzeller
force-pushed
the
feature-20241010-run-clang-tidy-review
branch
from
7295f9c
to
66e3c20
Compare
|
@hzeller do you get the same error when running it on your fork? https://github.com/hzeller/clang-tidy-pr-comments That would help us to rules out project specific configuration issues. |
| git diff -U1000 "$(git merge-base HEAD review-base/${{ github.event.pull_request.base.ref }})" | xls/dev_tools/run-clang-tidy-diff.sh -p1 -path build -export-fixes clang-tidy-result/fixes.yml | ||
|
|
||
| - name: Run clang-tidy-pr-comments action | ||
| uses: hzeller/clang-tidy-pr-comments@master |
There was a problem hiding this comment.
Note, I am using my fork here.
There was a problem hiding this comment.
Sorry I meant: when using the action on your xls fork (not a fork of the action).
There was a problem hiding this comment.
ah, I see. I did not try that as my personal github does not have access to hi-umpf runners (just building the compilation DB takes more than 30min before I gave up)
#xls-build-gardener