Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run goldens through mypy #1096

Closed
wants to merge 3 commits into from
Closed

ci: run goldens through mypy #1096

wants to merge 3 commits into from
+25 −1

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Nov 23, 2021 •
edited
Loading

For #1092.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 23, 2021
software-dov
software-dov reviewed Nov 23, 2021
View reviewed changes
Copy link
Contributor

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say from a CI perspective, just move the mypy check into the integration task.

@busunkim96 busunkim96 mentioned this pull request Jan 19, 2022
Closed
@parthea
Copy link
Contributor

parthea commented Jan 26, 2022

I'm going to merge this PR with #1132

@parthea parthea closed this Jan 26, 2022
@busunkim96 busunkim96 deleted the goldens-mypy branch April 7, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@software-dov software-dov software-dov left review comments

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busunkim96 @parthea @software-dov