Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presenter tests #182

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Add presenter tests #182

merged 1 commit into from
Jul 2, 2019

Conversation

blowmage
Copy link
Contributor

Add tests for the following:

  • GemPresenter
  • FilePresenter
  • PackagePresenter

[refs #173]

@blowmage blowmage requested a review from a team June 27, 2019 23:58
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 27, 2019
@blowmage
Copy link
Contributor Author

I had plans to mock File.read and test overriding the various gem methods that use the config, but didn't get to it.

quartzmo
quartzmo reviewed Jun 28, 2019
View reviewed changes
gapic-generator/templates/default/helpers/presenters/package_presenter.rb
@@ -27,8 +27,8 @@ def initialize api, package
@package = package
end

def def gem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught a good one there.

@quartzmo
Copy link
Member 

  1) Failure:
GoogleadsGemPresenterTest#test_googleads [/home/circleci/gapic-generator-ruby/gapic-generator/test/google/gapic/presenters/gem/googleads_test.rb:28]:
Expected: "Google Ads Googleads"
  Actual: "Google Ads GoogleAds"

quartzmo
quartzmo approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quartzmo quartzmo merged commit 63770c7 into googleapis:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

Assignees

@quartzmo quartzmo

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blowmage @quartzmo @googlebot