fix: correctly recognize oneofs and include them in the testing #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
viacheslav-rostovtsev
changed the title
dazuma
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the way the method_helper looked for oneof fields was to compare the oneof_index of the field descriptors; however oneof_index for the non-oneof fields is 0, the same as an index for the first oneof field.
This PR rectifies the issue. As a result, the tests for the methods that have an input with one of more oneof fields now correctly include all the non-oneof fields and the first field from each oneof group.
This PR also reverts the GetTypicalGarbage method to use TypicalGarbage as it's input so that the tests are generated for the gamut of the values that TypicalGarbage contains, including maps (and now oneof).
This method was changed to use a different input and as a result we were not generating any tests that include TypicalGarbage's fields.
The GetTypicalGarbage method that uses TypicalGarbageRequest is now a separate method called GetTypicalGarbageByRequest