Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Signet client subclasses no longer make the update! method private #516

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix: Signet client subclasses no longer make the update! method private #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/googleauth/compute_engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,6 @@ def fetch_access_token _options = {}
end
end

private

# Destructively updates these credentials.
#
# This method is called by `Signet::OAuth2::Client`'s constructor
Expand All @@ -177,6 +175,8 @@ def update! options = {}
self
end

private

def log_fetch_query
if token_type == :id_token
logger&.info do
Expand Down
4 changes: 2 additions & 2 deletions lib/googleauth/service_account.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,6 @@ def needs_access_token?
super && !enable_self_signed_jwt?
end

private

# Destructively updates these credentials
#
# This method is called by `Signet::OAuth2::Client`'s constructor
Expand All @@ -164,6 +162,8 @@ def update! options = {}
self
end

private

def apply_self_signed_jwt! a_hash
# Use the ServiceAccountJwtHeaderCredentials using the same cred values
cred_json = {
Expand Down
2 changes: 0 additions & 2 deletions lib/googleauth/user_refresh.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ def includes_scope? required_scope
missing_scope.empty?
end

private

# Destructively updates these credentials
#
# This method is called by `Signet::OAuth2::Client`'s constructor
Expand Down
Loading