impl(bigquerycontrol): promote from experimental to transitional

googleapis · Dec 9, 2024 · 62b91b5 · 62b91b5
1 parent e75d6e7
commit 62b91b5
Show file tree

Hide file tree

Showing 11 changed files with 23 additions and 28 deletions.
diff --git a/README.md b/README.md
@@ -140,6 +140,9 @@ See each library's `README.md` file for more information about:
 - [Google Cloud BigQuery](google/cloud/bigquery/README.md)
   [[quickstart]](google/cloud/bigquery/quickstart/README.md)
   [[reference]](https://cloud.google.com/cpp/docs/reference/bigquery/latest)
+- [BigQuery API](google/cloud/bigquerycontrol/README.md)
+  [[quickstart]](google/cloud/bigquerycontrol/quickstart/README.md)
+  [[reference]](https://cloud.google.com/cpp/docs/reference/bigquerycontrol/latest)
 - [Google Cloud Bigtable](google/cloud/bigtable/README.md)
   [[quickstart]](google/cloud/bigtable/quickstart/README.md)
   [[reference]](https://cloud.google.com/cpp/docs/reference/bigtable/latest)

diff --git a/cmake/GoogleCloudCppFeatures.cmake b/cmake/GoogleCloudCppFeatures.cmake
@@ -33,12 +33,11 @@ set(GOOGLE_CLOUD_CPP_NO_GRPC_FEATURES
 
 set(GOOGLE_CLOUD_CPP_EXPERIMENTAL_LIBRARIES
     # cmake-format: sort
-    "bigquerycontrol" # Some proto RPC comments indicate experimental methods.
     "pubsublite" # This is WIP, it needs a number of hand-crafted APIs.
 )
 
 set(GOOGLE_CLOUD_CPP_TRANSITION_LIBRARIES # cmake-format: sort
-                                          "storage_grpc")
+                                          "bigquerycontrol" "storage_grpc")
 
 set(GOOGLE_CLOUD_CPP_GA_LIBRARIES
     # cmake-format: sort

diff --git a/google/cloud/bigquerycontrol/BUILD.bazel b/google/cloud/bigquerycontrol/BUILD.bazel
@@ -84,7 +84,7 @@ cc_library(
     srcs = [sample],
     tags = ["integration-test"],
     deps = [
-        "//:experimental-bigquerycontrol",
+        "//:bigquerycontrol",
         "//google/cloud/testing_util:google_cloud_cpp_testing_private",
     ],
 ) for sample in glob([d + "samples/*.cc" for d in service_dirs])]
diff --git a/google/cloud/bigquerycontrol/CMakeLists.txt b/google/cloud/bigquerycontrol/CMakeLists.txt
@@ -79,13 +79,13 @@ target_link_libraries(
 google_cloud_cpp_add_common_options(google_cloud_cpp_bigquerycontrol)
 set_target_properties(
     google_cloud_cpp_bigquerycontrol
-    PROPERTIES EXPORT_NAME google-cloud-cpp::experimental-bigquerycontrol
+    PROPERTIES EXPORT_NAME google-cloud-cpp::bigquerycontrol
                VERSION "${PROJECT_VERSION}"
                SOVERSION "${PROJECT_VERSION_MAJOR}")
 target_compile_options(google_cloud_cpp_bigquerycontrol
                        PUBLIC ${GOOGLE_CLOUD_CPP_EXCEPTIONS_FLAG})
 
-add_library(google-cloud-cpp::experimental-bigquerycontrol ALIAS
+add_library(google-cloud-cpp::bigquerycontrol ALIAS
             google_cloud_cpp_bigquerycontrol)
 
 # Get the destination directories based on the GNU recommendations.
@@ -167,8 +167,7 @@ if (GOOGLE_CLOUD_CPP_WITH_MOCKS)
                    INTERFACE ${mock_files})
     target_link_libraries(
         google_cloud_cpp_bigquerycontrol_mocks
-        INTERFACE google-cloud-cpp::experimental-bigquerycontrol GTest::gmock
-                  GTest::gtest)
+        INTERFACE google-cloud-cpp::bigquerycontrol GTest::gmock GTest::gtest)
     set_target_properties(
         google_cloud_cpp_bigquerycontrol_mocks
         PROPERTIES EXPORT_NAME google-cloud-cpp::bigquerycontrol_mocks)
@@ -185,9 +184,8 @@ endif ()
 
 if (BUILD_TESTING AND GOOGLE_CLOUD_CPP_ENABLE_CXX_EXCEPTIONS)
     add_executable(bigquerycontrol_quickstart "quickstart/quickstart.cc")
-    target_link_libraries(
-        bigquerycontrol_quickstart
-        PRIVATE google-cloud-cpp::experimental-bigquerycontrol)
+    target_link_libraries(bigquerycontrol_quickstart
+                          PRIVATE google-cloud-cpp::bigquerycontrol)
     google_cloud_cpp_add_common_options(bigquerycontrol_quickstart)
     add_test(
         NAME bigquerycontrol_quickstart
@@ -199,11 +197,11 @@ endif ()
 
 add_subdirectory(integration_tests)
 
-# google-cloud-cpp::experimental-bigquerycontrol must be defined before we can
-# add the samples.
+# google-cloud-cpp::bigquerycontrol must be defined before we can add the
+# samples.
 foreach (dir IN LISTS service_dirs)
     if (BUILD_TESTING AND GOOGLE_CLOUD_CPP_ENABLE_CXX_EXCEPTIONS)
-        google_cloud_cpp_add_samples_relative("experimental-bigquerycontrol"
+        google_cloud_cpp_add_samples_relative("bigquerycontrol"
                                               "${dir}samples/")
     endif ()
 endforeach ()
diff --git a/google/cloud/bigquerycontrol/README.md b/google/cloud/bigquerycontrol/README.md
@@ -7,10 +7,8 @@ This directory contains an idiomatic C++ client library for the
 
 A data platform for customers to create, manage, share and query data.
 
-This library is **experimental**. Its APIs are subject to change without notice.
-
-Please, note that the Google Cloud C++ client libraries do **not** follow
-[Semantic Versioning](https://semver.org/).
+While this library is **GA**, please note Google Cloud C++ client libraries do
+ **not** follow [Semantic Versioning](https://semver.org/).
 
 ## Quickstart
 

diff --git a/google/cloud/bigquerycontrol/doc/main.dox b/google/cloud/bigquerycontrol/doc/main.dox
@@ -6,10 +6,8 @@ An idiomatic C++ client library for the [BigQuery API][cloud-service-docs].
 
 A data platform for customers to create, manage, share and query data.
 
-This library is **experimental**. Its APIs are subject to change without notice.
-
-Please, note that the Google Cloud C++ client libraries do **not** follow
-[Semantic Versioning](https://semver.org/).
+While this library is **GA**, please note Google Cloud C++ client libraries do
+ **not** follow [Semantic Versioning](https://semver.org/).
 
 @tableofcontents{HTML:2}
 

diff --git a/google/cloud/bigquerycontrol/integration_tests/BUILD.bazel b/google/cloud/bigquerycontrol/integration_tests/BUILD.bazel
@@ -24,7 +24,7 @@ licenses(["notice"])  # Apache 2.0
         "integration-test",
     ],
     deps = [
-        "//:experimental-bigquerycontrol",
+        "//:bigquerycontrol",
         "//google/cloud/testing_util:google_cloud_cpp_testing_private",
     ],
 ) for test in glob(["*_test.cc"])]
diff --git a/google/cloud/bigquerycontrol/integration_tests/CMakeLists.txt b/google/cloud/bigquerycontrol/integration_tests/CMakeLists.txt
@@ -31,9 +31,8 @@ foreach (fname ${bigquerycontrol_integration_tests})
     google_cloud_cpp_add_executable(target "bigquerycontrol" ${fname})
     target_link_libraries(
         ${target}
-        PRIVATE google-cloud-cpp::experimental-bigquerycontrol
-                google_cloud_cpp_testing GTest::gmock_main GTest::gmock
-                GTest::gtest)
+        PRIVATE google-cloud-cpp::bigquerycontrol google_cloud_cpp_testing
+                GTest::gmock_main GTest::gmock GTest::gtest)
     google_cloud_cpp_add_common_options(${target})
     add_test(NAME ${target} COMMAND ${target})
     set_tests_properties(

diff --git a/google/cloud/bigquerycontrol/quickstart/BUILD.bazel b/google/cloud/bigquerycontrol/quickstart/BUILD.bazel
@@ -20,6 +20,6 @@ cc_binary(
         "quickstart.cc",
     ],
     deps = [
-        "@google_cloud_cpp//:experimental-bigquerycontrol",
+        "@google_cloud_cpp//:bigquerycontrol",
     ],
 )
diff --git a/google/cloud/bigquerycontrol/quickstart/CMakeLists.txt b/google/cloud/bigquerycontrol/quickstart/CMakeLists.txt
@@ -29,4 +29,4 @@ endif ()
 
 # Define your targets.
 add_executable(quickstart quickstart.cc)
-target_link_libraries(quickstart google-cloud-cpp::experimental-bigquerycontrol)
+target_link_libraries(quickstart google-cloud-cpp::bigquerycontrol)
diff --git a/libraries.bzl b/libraries.bzl
@@ -17,11 +17,11 @@
 """Automatically generated unit tests list - DO NOT EDIT."""
 
 GOOGLE_CLOUD_CPP_EXPERIMENTAL_LIBRARIES = [
-    "bigquerycontrol",
     "pubsublite",
 ]
 
 GOOGLE_CLOUD_CPP_TRANSITION_LIBRARIES = [
+    "bigquerycontrol",
     "storage_grpc",
 ]