cleanup(storage): fix MOAR IWYU warnings, take 2

googleapis · Jul 23, 2024 · 657911a · 657911a
1 parent 413aac3
commit 657911a
Show file tree

Hide file tree

Showing 101 changed files with 116 additions and 0 deletions.
diff --git a/google/cloud/storage/async/client.cc b/google/cloud/storage/async/client.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/internal/async/default_options.h"
 #include "google/cloud/storage/internal/grpc/stub.h"
 #include "google/cloud/grpc_options.h"
+#include <memory>
 #include <string>
 #include <utility>
 #include <vector>

diff --git a/google/cloud/storage/async/client.h b/google/cloud/storage/async/client.h
@@ -28,6 +28,7 @@
 #include "google/cloud/internal/group_options.h"
 #include "google/cloud/status_or.h"
 #include <google/storage/v2/storage.pb.h>
+#include <memory>
 #include <string>
 #include <utility>
 #include <vector>

diff --git a/google/cloud/storage/async/client_test.cc b/google/cloud/storage/async/client_test.cc
@@ -21,6 +21,7 @@
 #include "google/cloud/testing_util/status_matchers.h"
 #include <google/protobuf/text_format.h>
 #include <gmock/gmock.h>
+#include <memory>
 #include <string>
 #include <utility>
 

diff --git a/google/cloud/storage/async/idempotency_policy.cc b/google/cloud/storage/async/idempotency_policy.cc
@@ -13,6 +13,7 @@
 // limitations under the License.
 
 #include "google/cloud/storage/async/idempotency_policy.h"
+#include <memory>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/async/reader.cc b/google/cloud/storage/async/reader.cc
@@ -15,6 +15,7 @@
 #include "google/cloud/storage/async/reader.h"
 #include "google/cloud/storage/async/reader_connection.h"
 #include "google/cloud/internal/make_status.h"
+#include <memory>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/async/reader_test.cc b/google/cloud/storage/async/reader_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/testing_util/async_sequencer.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/async/resume_policy.cc b/google/cloud/storage/async/resume_policy.cc
@@ -13,6 +13,7 @@
 // limitations under the License.
 
 #include "google/cloud/storage/async/resume_policy.h"
+#include <memory>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/async/rewriter.cc b/google/cloud/storage/async/rewriter.cc
@@ -14,6 +14,7 @@
 
 #include "google/cloud/storage/async/rewriter.h"
 #include "google/cloud/internal/make_status.h"
+#include <memory>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/async/rewriter_test.cc b/google/cloud/storage/async/rewriter_test.cc
@@ -17,6 +17,7 @@
 #include "google/cloud/storage/testing/canonical_errors.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/async/writer.cc b/google/cloud/storage/async/writer.cc
@@ -14,6 +14,7 @@
 
 #include "google/cloud/storage/async/writer.h"
 #include "google/cloud/internal/make_status.h"
+#include <memory>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/async/writer_test.cc b/google/cloud/storage/async/writer_test.cc
@@ -17,6 +17,7 @@
 #include "google/cloud/storage/testing/canonical_errors.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <string>
 #include <utility>
 

diff --git a/google/cloud/storage/benchmarks/aggregate_download_throughput_benchmark.cc b/google/cloud/storage/benchmarks/aggregate_download_throughput_benchmark.cc
@@ -29,6 +29,9 @@
 #include <atomic>
 #include <future>
 #include <iomanip>
+#include <iostream>
+#include <map>
+#include <mutex>
 #include <random>
 #include <sstream>
 #include <string>

diff --git a/google/cloud/storage/benchmarks/aggregate_download_throughput_options.cc b/google/cloud/storage/benchmarks/aggregate_download_throughput_options.cc
@@ -16,6 +16,7 @@
 #include "google/cloud/grpc_options.h"
 #include "google/cloud/internal/absl_str_join_quiet.h"
 #include "google/cloud/internal/make_status.h"
+#include <iostream>
 #include <iterator>
 #include <sstream>
 #include <string>

diff --git a/google/cloud/storage/benchmarks/aggregate_upload_throughput_benchmark.cc b/google/cloud/storage/benchmarks/aggregate_upload_throughput_benchmark.cc
@@ -27,6 +27,7 @@
 #include "google/cloud/testing_util/timer.h"
 #include "absl/strings/str_format.h"
 #include "absl/time/time.h"
+#include <mutex>
 
 namespace {
 using ::google::cloud::testing_util::FormatSize;

diff --git a/google/cloud/storage/benchmarks/aggregate_upload_throughput_options.cc b/google/cloud/storage/benchmarks/aggregate_upload_throughput_options.cc
@@ -15,6 +15,7 @@
 #include "google/cloud/storage/benchmarks/aggregate_upload_throughput_options.h"
 #include "google/cloud/grpc_options.h"
 #include "google/cloud/internal/absl_str_join_quiet.h"
+#include <iostream>
 #include <iterator>
 #include <sstream>
 #include <string>

diff --git a/google/cloud/storage/benchmarks/async_throughput_benchmark.cc b/google/cloud/storage/benchmarks/async_throughput_benchmark.cc
@@ -29,6 +29,8 @@
 #include <chrono>
 #include <cstdint>
 #include <iostream>
+#include <map>
+#include <memory>
 #include <random>
 #include <stdexcept>
 #include <string>

diff --git a/google/cloud/storage/benchmarks/benchmark_utils.cc b/google/cloud/storage/benchmarks/benchmark_utils.cc
@@ -28,6 +28,7 @@
 #include "absl/strings/strip.h"
 #include "absl/time/time.h"
 #include <future>
+#include <iostream>
 #include <sstream>
 #include <string>
 #include <utility>

diff --git a/google/cloud/storage/benchmarks/create_dataset.cc b/google/cloud/storage/benchmarks/create_dataset.cc
@@ -23,6 +23,7 @@
 #include <cstdlib>
 #include <future>
 #include <iomanip>
+#include <iostream>
 #include <sstream>
 #include <string>
 #include <vector>

diff --git a/google/cloud/storage/benchmarks/create_dataset_options.cc b/google/cloud/storage/benchmarks/create_dataset_options.cc
@@ -14,6 +14,7 @@
 
 #include "google/cloud/storage/benchmarks/create_dataset_options.h"
 #include "google/cloud/internal/make_status.h"
+#include <iostream>
 #include <sstream>
 #include <string>
 #include <utility>

diff --git a/google/cloud/storage/benchmarks/storage_file_transfer_benchmark.cc b/google/cloud/storage/benchmarks/storage_file_transfer_benchmark.cc
@@ -23,6 +23,7 @@
 #include <fstream>
 #include <future>
 #include <iomanip>
+#include <iostream>
 #include <sstream>
 #include <string>
 #include <utility>

diff --git a/google/cloud/storage/benchmarks/storage_parallel_uploads_benchmark.cc b/google/cloud/storage/benchmarks/storage_parallel_uploads_benchmark.cc
@@ -24,6 +24,8 @@
 #include <cstdio>
 #include <future>
 #include <iomanip>
+#include <iostream>
+#include <mutex>
 #include <sstream>
 #include <string>
 #include <utility>

diff --git a/google/cloud/storage/benchmarks/storage_throughput_vs_cpu_benchmark.cc b/google/cloud/storage/benchmarks/storage_throughput_vs_cpu_benchmark.cc
@@ -27,6 +27,10 @@
 #include "absl/time/time.h"
 #include <functional>
 #include <future>
+#include <iostream>
+#include <map>
+#include <memory>
+#include <mutex>
 #include <set>
 #include <sstream>
 #include <string>

diff --git a/google/cloud/storage/benchmarks/throughput_experiment.cc b/google/cloud/storage/benchmarks/throughput_experiment.cc
@@ -20,6 +20,7 @@
 #include "google/cloud/storage/internal/grpc/ctype_cord_workaround.h"
 #include "google/cloud/grpc_error_delegate.h"
 #include <google/storage/v2/storage.grpc.pb.h>
+#include <memory>
 #include <string>
 #include <utility>
 #endif  // GOOGLE_CLOUD_CPP_STORAGE_HAVE_GRPC

diff --git a/google/cloud/storage/benchmarks/throughput_options.cc b/google/cloud/storage/benchmarks/throughput_options.cc
@@ -19,6 +19,7 @@
 #include "google/cloud/internal/make_status.h"
 #include "absl/strings/str_split.h"
 #include "absl/time/time.h"
+#include <iostream>
 #include <sstream>
 #include <string>
 #include <utility>

diff --git a/google/cloud/storage/examples/storage_async_mock_samples.cc b/google/cloud/storage/examples/storage_async_mock_samples.cc
@@ -17,6 +17,7 @@
 #include "google/cloud/storage/mocks/mock_async_reader_connection.h"
 #include <gmock/gmock.h>
 #include <iostream>
+#include <memory>
 #include <string>
 #include <utility>
 

diff --git a/google/cloud/storage/examples/storage_client_mock_samples.cc b/google/cloud/storage/examples/storage_client_mock_samples.cc
@@ -17,6 +17,7 @@
 #include "google/cloud/storage/testing/mock_client.h"
 #include <gmock/gmock.h>
 #include <iostream>
+#include <memory>
 #include <string>
 #include <utility>
 

diff --git a/google/cloud/storage/internal/bucket_metadata_parser.cc b/google/cloud/storage/internal/bucket_metadata_parser.cc
@@ -21,6 +21,7 @@
 #include "absl/strings/str_format.h"
 #include <nlohmann/json.hpp>
 #include <functional>
+#include <map>
 #include <string>
 #include <utility>
 #include <vector>

diff --git a/google/cloud/storage/internal/bucket_requests.cc b/google/cloud/storage/internal/bucket_requests.cc
@@ -19,6 +19,7 @@
 #include "google/cloud/internal/absl_str_join_quiet.h"
 #include "google/cloud/internal/format_time_point.h"
 #include <nlohmann/json.hpp>
+#include <map>
 #include <sstream>
 #include <string>
 #include <utility>

diff --git a/google/cloud/storage/internal/connection_factory.cc b/google/cloud/storage/internal/connection_factory.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/internal/generic_stub_factory.h"
 #include "google/cloud/storage/internal/tracing_connection.h"
 #include "google/cloud/internal/opentelemetry.h"
+#include <memory>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/connection_impl.cc b/google/cloud/storage/internal/connection_impl.cc
@@ -19,6 +19,7 @@
 #include "absl/strings/match.h"
 #include <chrono>
 #include <functional>
+#include <memory>
 #include <sstream>
 #include <string>
 #include <thread>

diff --git a/google/cloud/storage/internal/connection_impl.h b/google/cloud/storage/internal/connection_impl.h
@@ -21,6 +21,7 @@
 #include "google/cloud/storage/retry_policy.h"
 #include "google/cloud/storage/version.h"
 #include "google/cloud/internal/invocation_id_generator.h"
+#include <memory>
 #include <string>
 #include <vector>
 

diff --git a/google/cloud/storage/internal/connection_impl_bucket_acl_test.cc b/google/cloud/storage/internal/connection_impl_bucket_acl_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/testing/mock_generic_stub.h"
 #include "google/cloud/storage/testing/retry_tests.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/internal/connection_impl_bucket_test.cc b/google/cloud/storage/internal/connection_impl_bucket_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/testing/mock_generic_stub.h"
 #include "google/cloud/storage/testing/retry_tests.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/internal/connection_impl_default_object_acl_test.cc b/google/cloud/storage/internal/connection_impl_default_object_acl_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/testing/mock_generic_stub.h"
 #include "google/cloud/storage/testing/retry_tests.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/internal/connection_impl_notifications_test.cc b/google/cloud/storage/internal/connection_impl_notifications_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/testing/mock_generic_stub.h"
 #include "google/cloud/storage/testing/retry_tests.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/internal/connection_impl_object_acl_test.cc b/google/cloud/storage/internal/connection_impl_object_acl_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/testing/mock_generic_stub.h"
 #include "google/cloud/storage/testing/retry_tests.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/internal/connection_impl_object_copy_test.cc b/google/cloud/storage/internal/connection_impl_object_copy_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/testing/mock_generic_stub.h"
 #include "google/cloud/storage/testing/retry_tests.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/internal/connection_impl_object_test.cc b/google/cloud/storage/internal/connection_impl_object_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/testing/mock_generic_stub.h"
 #include "google/cloud/storage/testing/retry_tests.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/internal/connection_impl_service_account_test.cc b/google/cloud/storage/internal/connection_impl_service_account_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/testing/mock_generic_stub.h"
 #include "google/cloud/storage/testing/retry_tests.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/internal/connection_impl_sign_blob_test.cc b/google/cloud/storage/internal/connection_impl_sign_blob_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/testing/mock_generic_stub.h"
 #include "google/cloud/storage/testing/retry_tests.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <utility>
 
 namespace google {

diff --git a/google/cloud/storage/internal/generic_stub.h b/google/cloud/storage/internal/generic_stub.h
@@ -37,6 +37,7 @@
 #include "google/cloud/status.h"
 #include "google/cloud/status_or.h"
 #include "google/cloud/version.h"
+#include <memory>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/generic_stub_factory.cc b/google/cloud/storage/internal/generic_stub_factory.cc
@@ -17,6 +17,7 @@
 #include "google/cloud/storage/internal/rest/stub.h"
 #include "google/cloud/storage/options.h"
 #include "google/cloud/internal/algorithm.h"
+#include <memory>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/hash_function_impl_test.cc b/google/cloud/storage/internal/hash_function_impl_test.cc
@@ -19,6 +19,7 @@
 #include "google/cloud/storage/testing/upload_hash_cases.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <string>
 #include <utility>
 

diff --git a/google/cloud/storage/internal/hash_validator.cc b/google/cloud/storage/internal/hash_validator.cc
@@ -16,6 +16,7 @@
 #include "google/cloud/storage/internal/hash_validator_impl.h"
 #include "google/cloud/storage/internal/object_requests.h"
 #include "google/cloud/storage/object_metadata.h"
+#include <memory>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/hash_validator_impl.h b/google/cloud/storage/internal/hash_validator_impl.h
@@ -17,6 +17,7 @@
 
 #include "google/cloud/storage/internal/hash_validator.h"
 #include "google/cloud/storage/version.h"
+#include <memory>
 #include <string>
 #include <utility>
 

diff --git a/google/cloud/storage/internal/hash_validator_test.cc b/google/cloud/storage/internal/hash_validator_test.cc
@@ -19,6 +19,7 @@
 #include "google/cloud/storage/internal/object_requests.h"
 #include "google/cloud/storage/testing/upload_hash_cases.h"
 #include <gmock/gmock.h>
+#include <memory>
 #include <string>
 #include <utility>
 

diff --git a/google/cloud/storage/internal/impersonate_service_account_credentials.cc b/google/cloud/storage/internal/impersonate_service_account_credentials.cc
@@ -15,6 +15,8 @@
 #include "google/cloud/storage/internal/impersonate_service_account_credentials.h"
 #include "google/cloud/internal/rest_client.h"
 #include "google/cloud/internal/unified_rest_credentials.h"
+#include <memory>
+#include <mutex>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/impersonate_service_account_credentials.h b/google/cloud/storage/internal/impersonate_service_account_credentials.h
@@ -19,6 +19,7 @@
 #include "google/cloud/storage/version.h"
 #include "google/cloud/credentials.h"
 #include "google/cloud/internal/oauth2_minimal_iam_credentials_rest.h"
+#include <memory>
 #include <mutex>
 #include <string>
 

diff --git a/google/cloud/storage/internal/logging_stub.cc b/google/cloud/storage/internal/logging_stub.cc
@@ -15,6 +15,7 @@
 #include "google/cloud/storage/internal/logging_stub.h"
 #include "google/cloud/internal/invoke_result.h"
 #include "google/cloud/log.h"
+#include <memory>
 #include <string>
 #include <utility>
 #include <vector>