Skip to content

Commit

Permalink
use experimental target in quickstarts for now
Browse files Browse the repository at this point in the history
  • Loading branch information
scotthart committed Dec 11, 2024
1 parent 00b4d4a commit cadf39c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 10 deletions.
2 changes: 0 additions & 2 deletions ci/cloudbuild/builds/quickstart-cmake.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ readonly SED_ARGS=(
# The vcpkg maintainers introduced an `rpc` feature to just compile
# `grpc-common`.
-e '/^rpc$/d'
# TODO(#14891) - skip until next release
-e '/^bigquerycontrol/d'
)
mapfile -t features < <(
env -C "${vcpkg_dir}" ./vcpkg search google-cloud-cpp |
Expand Down
10 changes: 4 additions & 6 deletions google/cloud/bigquerycontrol/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,13 @@

include(GoogleCloudCppLibrary)

google_cloud_cpp_add_gapic_library(
bigquerycontrol "Cloud BigQuery Control API" REST_TRANSPORT
SERVICE_DIRS "v2/")
google_cloud_cpp_add_gapic_library(bigquerycontrol "Cloud BigQuery Control API"
REST_TRANSPORT SERVICE_DIRS "v2/")

if (BUILD_TESTING AND GOOGLE_CLOUD_CPP_ENABLE_CXX_EXCEPTIONS)
add_executable(bigquerycontrol_quickstart "quickstart/quickstart.cc")
target_link_libraries(
bigquerycontrol_quickstart
PRIVATE google-cloud-cpp::bigquerycontrol)
target_link_libraries(bigquerycontrol_quickstart
PRIVATE google-cloud-cpp::bigquerycontrol)
google_cloud_cpp_add_common_options(bigquerycontrol_quickstart)
add_test(
NAME bigquerycontrol_quickstart
Expand Down
3 changes: 2 additions & 1 deletion google/cloud/bigquerycontrol/quickstart/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ cc_binary(
"quickstart.cc",
],
deps = [
"@google_cloud_cpp//:bigquerycontrol",
# TODO(#14891): switch to GA target
"@google_cloud_cpp//:experimental-bigquerycontrol",
],
)
3 changes: 2 additions & 1 deletion google/cloud/bigquerycontrol/quickstart/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,5 @@ endif ()

# Define your targets.
add_executable(quickstart quickstart.cc)
target_link_libraries(quickstart google-cloud-cpp::bigquerycontrol)
# TODO(#14891): switch to GA target.
target_link_libraries(quickstart google-cloud-cpp::experimental-bigquerycontrol)

0 comments on commit cadf39c

Please sign in to comment.