Skip to content

Commit

Permalink
test(GCS+gRPC): skip another integration test
Browse files Browse the repository at this point in the history
This one does not work against production, and it may never work against
production. Disable it until I can get an authoritative answer.
  • Loading branch information
coryan committed Jun 28, 2024
1 parent f384d1a commit d06ba82
Showing 1 changed file with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ class GrpcNotificationIntegrationTest
: public google::cloud::storage::testing::StorageIntegrationTest {};

TEST_F(GrpcNotificationIntegrationTest, NotificationCRUD) {
// TODO(#14396) - figure out what to do with the Notifications and gRPC
if (UsingGrpc()) GTEST_SKIP();

ScopedEnvironment grpc_config("GOOGLE_CLOUD_CPP_STORAGE_GRPC_CONFIG",
"metadata");

auto const project_id = GetEnv("GOOGLE_CLOUD_PROJECT").value_or("");
ASSERT_THAT(project_id, Not(IsEmpty())) << "GOOGLE_CLOUD_PROJECT is not set";
auto const topic_name = google::cloud::internal::GetEnv(
Expand All @@ -55,9 +61,6 @@ TEST_F(GrpcNotificationIntegrationTest, NotificationCRUD) {
ASSERT_STATUS_OK(metadata);
ScheduleForDelete(*metadata);

ScopedEnvironment grpc_config("GOOGLE_CLOUD_CPP_STORAGE_GRPC_CONFIG",
"metadata");

auto marker = google::cloud::internal::Sample(
generator_, 16, "abcdefghijklmnopqrstuvwxyz0123456789");
auto create = client->CreateNotification(
Expand Down

0 comments on commit d06ba82

Please sign in to comment.