impl(rest): leverage EmptyResponseType to remove ambiguities in Post and Delete template functions #14390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and Delete template functions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14390 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 2191 2191
Lines 193212 193260 +48
=======================================
+ Hits 179821 179866 +45
- Misses 13391 13394 +3 ☔ View full report in Codecov by Sentry. |
dbolduc
approved these changes
Jun 27, 2024
| template <typename Request> | ||
| template < | ||
| typename Response, typename Request, | ||
| std::enable_if_t<std::is_same<Response, EmptyResponseType>::value, int> = 0> | ||
| Status Delete( | ||
| rest_internal::RestClient& client, rest_internal::RestContext& rest_context, | ||
| Request const&, bool, std::string path, |
There was a problem hiding this comment.
comment that predates this PR: the unused request parameter looked strange to me, but I see that
- the contents of
requestare used to makepath - it lets us consolidate generator code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14382
Upcoming BigQuery Post calls introduce cases where
ResponseandRequesttypes are the same. This PR resolves an ambiguity that introduces in the current template function definitions.This change is