Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(generator): relocate FormatQueryParameterCode #14513

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jul 20, 2024

Part of the work for #14510

This is a pure refactor. I will be getting rid of this visitor. To keep the diffs small, pull out the FormatQueryParameterCode function first.

Note that we:

  • add method as a parameter
  • return a std::string, instead of setting method_http_query_parameters in the function

This change is Reviewable

@dbolduc dbolduc changed the title refactor(generator): relocate FormatQueryParameters refactor(generator): relocate FormatQueryParameterCode Jul 20, 2024
@dbolduc dbolduc marked this pull request as ready for review July 20, 2024 07:44
@dbolduc dbolduc requested a review from a team as a code owner July 20, 2024 07:44
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (3fed367) to head (4465cf2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14513   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files        2316     2316           
  Lines      207105   207100    -5     
=======================================
- Hits       193838   193835    -3     
+ Misses      13267    13265    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc merged commit 20af944 into googleapis:main Jul 20, 2024
63 checks passed
@dbolduc dbolduc deleted the refactor-format-query-params branch July 20, 2024 13:56
cuiy0006 pushed a commit to cuiy0006/google-cloud-cpp that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants