Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(GCS+gRPC): simplify integration tests #14514

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 20, 2024

Part of the work for #14399


This change is Reviewable

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (4c40596) to head (ec8a289).

Files Patch % Lines
...oogle/cloud/storage/tests/grpc_integration_test.cc 83.33% 3 Missing ⚠️
.../cloud/storage/testing/storage_integration_test.cc 93.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14514   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files        2316     2316           
  Lines      207113   207110    -3     
=======================================
- Hits       193841   193840    -1     
+ Misses      13272    13270    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review July 20, 2024 16:27
@coryan coryan requested review from a team as code owners July 20, 2024 16:27
@coryan coryan merged commit ff999ec into googleapis:main Jul 20, 2024
63 checks passed
@coryan coryan deleted the test-storage-simplify-grpc-initialization branch July 20, 2024 19:38
cuiy0006 pushed a commit to cuiy0006/google-cloud-cpp that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants