cleanup(storage): prefer MakeIntegrationTestClient()
#14515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the common function to initialize the `storage::Client` object.
product-auto-label
bot
added
the
api: storage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14515 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 2316 2316
Lines 207113 207130 +17
=======================================
+ Hits 193841 193862 +21
+ Misses 13272 13268 -4 ☔ View full report in Codecov by Sentry. |
dbolduc
approved these changes
Jul 20, 2024
| struct ObjectBasicCRUDIntegrationTest | ||
| : public ::google::cloud::storage::testing::ObjectIntegrationTest { | ||
| public: | ||
| static Client MakeNonDefaultClient() { |
There was a problem hiding this comment.
this isn't obviously the same, but I will bet that you know what you are doing without digging deeper.
There was a problem hiding this comment.
Ack. Thanks. I reviewed again just to make sure.
cuiy0006
pushed a commit
to cuiy0006/google-cloud-cpp
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the common function to initialize the
storage::Clientobject.This change is